Repository navigation
Fix wheel compilation and nightly QP regressions - #2923
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the develop wheel build failure and the distinct failures reported in #2915, based on develop
444863c614609e0e4ec5e8c80819243cd14c815d.cachedOrdering, which triggers GCC's-Werror=dangling-referencein the wheel builds and Linux vcpkg build. Preserve cached ordering by reference and test the explicit LP ordering path.SparseQpSolverusing the existing factorization. Re-solving with the stored affine right-hand side reintroduces cancellation along weak directions. Keep the existing bound-release regression and add a deterministic unequal-column regression.QPSolversupplied-point contract by selecting Primal explicitly. Automatic can select Dual, which accepts infeasible starts; the legacy interface must reject them. Cover both supplied-point overloads without relaxing the original solution tolerance.5e-9forward-error threshold withepsilon * condition * solution magnitude, derived from its reduced Hessian. Its condition number is about 4.03e6. Retain the1e-12affine-residual assertion and add a separate1e-12reduced-gradient assertion.Failure evidence
4413fb8and current develop only affected the Dense backend, not these failing paths.Validation
GCC 14.2 Release, bundled Eigen, Boost/TBB disabled, deprecated APIs and unstable enabled:
testActiveSetSolverOptions,testDenseQpSolver,testDualQpSolver,testLpProblem,testLpSolver,testQpInitialization,testQpProblem,testQpSolver,testSparseQpSolver, andtestQPSolvervia their.runtargets.-Werror=dangling-reference; the modified source compiles with that warning still an error.SquareRootAffineRhsRefinementregression fails to converge with the original sparse implementation preloaded and passes with the fixed implementation.git diff --checkpassed.Native ARM, Windows, conda/vcpkg and wheel matrix verification remains pending; this is a draft, not a claim that the full matrix is already green.
Refs #2915.